Skip to content

Feature 1789 - Add mobile number column to system imports for volunteers#3372

Merged
compwron merged 4 commits into
rubyforgood:mainfrom
frankljin:feature-1789
Apr 15, 2022
Merged

Feature 1789 - Add mobile number column to system imports for volunteers#3372
compwron merged 4 commits into
rubyforgood:mainfrom
frankljin:feature-1789

Conversation

@frankljin
Copy link
Copy Markdown
Collaborator

What github issue is this PR for, if any?

Resolves #1789

What changed, and why?

Bulk import capabilities for volunteer phone numbers as requested in #1789.

In volunteer_importer:

  • If phone number associated with volunteer already exists, then it is overridden
  • Existing accounts get updated accordingly with phone number imports

How will this affect user permissions?

  • Volunteer permissions: None
  • Supervisor permissions: None
  • Admin permissions: None

How is this tested? (please write tests!) 💖💪

In volunteer_importer_spec:

  • Updating existing volunteers (with and without phone numbers)
  • Invalid phone numbers, removing phone numbers

Screenshots please :)

Screen Shot 2022-04-15 at 1 01 18 AM

Screen Shot 2022-04-15 at 1 01 35 AM

Copy link
Copy Markdown
Collaborator

@harsohailB harsohailB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Collaborator

@xihai01 xihai01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Looks good

Copy link
Copy Markdown
Collaborator

@7riumph 7riumph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM

@frankljin frankljin marked this pull request as ready for review April 15, 2022 21:23
@compwron compwron merged commit 6d298a9 into rubyforgood:main Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ruby Touches Ruby code 🧪 Tests Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add mobile number column to system imports for volunteers

5 participants