Skip to content

Replace webpacker with updating gems#3398

Merged
FireLemons merged 49 commits into
rubyforgood:mainfrom
FireLemons:replace_webpacker_with_jsbundling_rails_esbuild
May 25, 2022
Merged

Replace webpacker with updating gems#3398
FireLemons merged 49 commits into
rubyforgood:mainfrom
FireLemons:replace_webpacker_with_jsbundling_rails_esbuild

Conversation

@FireLemons
Copy link
Copy Markdown
Collaborator

@FireLemons FireLemons commented Apr 27, 2022

What github issue is this PR for, if any?

Resolves #3356

What changed, and why?

How will this affect user permissions?

  • Volunteer permissions:
  • Supervisor permissions:
  • Admin permissions:

How is this tested? (please write tests!) 💖💪

Screenshots please :)

Feelings gif (optional)

What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
![alt text](https://media.giphy.com/media/1nP7ThJFes5pgXKUNf/giphy.gif)

Feedback please? (optional)

We are very interested in your feedback! Please give us some :) https://forms.gle/1D5ACNgTs2u9gSdh9

@github-actions github-actions Bot added dependencies Touches dependency files erb Touches ERB templates javascript Touches JavaScript code ruby Touches Ruby code labels Apr 27, 2022
@FireLemons FireLemons force-pushed the replace_webpacker_with_jsbundling_rails_esbuild branch 2 times, most recently from 044eb21 to 3f2f751 Compare May 4, 2022 01:38
@compwron
Copy link
Copy Markdown
Collaborator

compwron commented May 8, 2022

:)

@FireLemons FireLemons force-pushed the replace_webpacker_with_jsbundling_rails_esbuild branch 4 times, most recently from 9f9f199 to 5c06599 Compare May 18, 2022 01:00
@FireLemons
Copy link
Copy Markdown
Collaborator Author

image

@FireLemons FireLemons force-pushed the replace_webpacker_with_jsbundling_rails_esbuild branch from a7f4c44 to 3c62f5a Compare May 20, 2022 04:26
@FireLemons FireLemons marked this pull request as draft May 21, 2022 05:38
@FireLemons FireLemons force-pushed the replace_webpacker_with_jsbundling_rails_esbuild branch from e882b7f to 9360098 Compare May 25, 2022 01:08
@FireLemons FireLemons marked this pull request as ready for review May 25, 2022 01:19
Copy link
Copy Markdown
Collaborator

@compwron compwron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems legit! Let's make sure that the readme is clear for new and existing contributors :)

@FireLemons FireLemons force-pushed the replace_webpacker_with_jsbundling_rails_esbuild branch from 9360098 to 3e70eb8 Compare May 25, 2022 02:18
@FireLemons FireLemons force-pushed the replace_webpacker_with_jsbundling_rails_esbuild branch from f31df54 to 570f375 Compare May 25, 2022 02:47
@FireLemons FireLemons merged commit 1c9d571 into rubyforgood:main May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Touches dependency files erb Touches ERB templates javascript Touches JavaScript code ruby Touches Ruby code 🧪 Tests Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate webpacker

2 participants