Feature/1781 Twilio is integrated with app for event triggered notifications

[harsohailB]

What github issue is this PR for, if any?

Resolves #1781

What changed, and why?

• Added Twilio Account SID, Twilio API Key SID, Twilio API Key Secret, and Twilio Phone Number under the "Edit Organization" tab

These are given by Twilio in their console as follows:

A POST request like the following is sent to send an SMS which requires these three parameters:

• Changed CasaOrg model to store the three attributes

curl -X POST https://api.twilio.com/2010-04-01/Accounts/${TWILIO_ACCOUNT_SID}/Messages.json \
                --data-urlencode "Body=Hello from Twilio" \
                --data-urlencode "From=${TWILIO_PHONE_NUMBER}" \
                --data-urlencode "To=${RECIPIENT NUMBER}" \
                -u ${TWILIO_API_KEY_SID}:${TWILIO_API_KEY_SECRET}

How will this affect user permissions?

• Volunteer permissions: n/a
• Supervisor permissions: n/a
• Admin permissions: n/a

How is this tested? (please write tests!) 💖💪

• Wrote view tests for the "Edit Organization" page which now contains Twilio inputs
• Wrote requests tests to verify update requests for a CasaOrg (invalid phone number input not accepted)

Screenshots please :)

[xihai01]

awesome stuff! 😄 Left a few comments for you. I also have a suggestion. According to the Twilio docs, they recommend using API keys since they aren't attached to the main account and can be easily issued and revoked: https://www.twilio.com/docs/usage/rest-api-best-practices#control-access-to-your-accounts

[compwron]

Yes, API keys :)

[harsohailB]

awesome stuff! 😄 Left a few comments for you. I also have a suggestion. According to the Twilio docs, they recommend using API keys since they aren't attached to the main account and can be easily issued and revoked: https://www.twilio.com/docs/usage/rest-api-best-practices#control-access-to-your-accounts

Refactored to use API keys instead. Updated the description (curl request + pics) on how I understand they work.

[7riumph]

Edit: misread an above comment/am not seeing multiple credentials in the codebase

[7riumph]

Nice! @xihai01 has great comments too 🔥

[xihai01]

@harsohailB Don't forget to update the screenshot

[xihai01]

LGTM

[compwron]

Failing tests are

rspec ./spec/system/casa_org/edit_spec.rb:96 # casa_org/edit can update show_driving_reimbursement flag
rspec ./spec/system/casa_org/edit_spec.rb:106 # casa_org/edit can upload a logo image
rspec ./spec/requests/casa_org_spec.rb:36 # CasaOrg as an admin PATCH /update with valid parameters doesn't revert logo to default if non logo details are updated
rspec ./spec/requests/casa_org_spec.rb:22 # CasaOrg as an admin PATCH /update with valid parameters updates the requested casa_org
rspec ./spec/requests/casa_org_spec.rb:44 # CasaOrg as an admin PATCH /update with valid parameters redirects to the casa_org
rspec ./spec/requests/casa_org_spec.rb:50 # CasaOrg as an admin PATCH /update with valid parameters also responds as json

[xihai01]

great!

[harsohailB]

During production deployment, we will need to put RAILS_MASTER_KEY as an environment variable in Heroku so the production.yml.enc file can be decrypted.

[compwron]

:)

[xihai01]

@harsohailB tests are failing. Seems like you need to run a migration