Feature/1784 - All users recieve account activation SMS

[xihai01]

What github issue is this PR for, if any?

Resolves #1784

What changed, and why?

• Within application controller, a function called deliver_sms_to() is created to instantiate a new Twilio client and send a SMS
• Refactored spec/support/webmock_helper.rb by creating each stub in their own functions within a module. This is so each function can return the stub that we can use in the tests (for example, asserting how many times a stub was called)
• In /config/initializers/constants.rb, a module is created to hold the body messages of SMS notifications to be sent.

To do (features)

• Implement @harsohailB suggestion to re-structure webmock for clarity
• Research how Twilio handles errors (ex. incorrect phone numbers) and apply a fix
• Refactor

How is this tested? (please write tests!) 💖💪

• Request specs are written for volunteer/supervisor/admin controllers where: phone number is provided, phone number is not provided and when Twilio responds back with an error. In each case, we look for if the correct stub was called, redirect and the appropriate flash notices

Screenshots please :)

Here is an example of a supervisor created successfully with a SMS sent.

Here is a case when the user makes a typo in their phone number. User still gets created, but SMS not sent.

Feelings gif (optional)

My 💰 don't 🤹 🤹 it folds

Feedback please? (optional)

We are very interested in your feedback! Please give us some :) https://forms.gle/1D5ACNgTs2u9gSdh9

[compwron]

Please fix lint and the tests :)

[compwron]

Please fit the git conflicts :)

[xihai01]

Please fit the git conflicts :)

ok, will do

[xihai01]

50% done issue. Still working. Will fix and refactor tests, lints, you name it near the end

[compwron]

Codeclimate is failing on duplicate code blocks

[compwron]

Also there are some git conflicts to resolve...

[xihai01]

Also there are some git conflicts to resolve...

yes, I will work on the conflicts asap. Once everything is good, I'll open this issue.

[harsohailB]

Can we put these stubbed request modules in their own files for easier maintainability?

[xihai01]

so instead of modules, you want to put twilio stubs and short io stubs into their own separate files?

[harsohailB]

I believe we can still have them as modules but have a hierarchy as follows for clarity and seperation:

-- support
    -- subbed_requests
        -- twilio_api.rb
        -- short_io_api.rb

A file such as twilio_api.rb would look like this:

# twilio_api.rb

module StubbedRequests
    module TwilioAPI
        def self.allowed_sites(blacklist)
             lambda { |uri|
                 blacklist.none? { |site| uri.host.include?(site) }
             }
        end

        # stubs
    end
end

[xihai01]

I like that idea. Very clear.

[xihai01]

fixed codeclimate issue and rspec tests are passing. Before I lint and open this issue for review, I will do the following:

• - Implement @harsohailB changes to webmock structure
• - Implement error handling for the case where user enters a correctly formatted phone number, but invalid

[compwron]

these extraneous comment changes are not ideal but they are common. Don't worry about them for now.

[xihai01]

thats weird.. i never touched any model files

[compwron]

TODO replace all "blacklist" with "disallowlist"