Skip to content

#1794 Volunteer receives SMS reminder to submit court report#3656

Merged
compwron merged 7 commits into
rubyforgood:mainfrom
harsohailB:feature/1794
Jun 26, 2022
Merged

#1794 Volunteer receives SMS reminder to submit court report#3656
compwron merged 7 commits into
rubyforgood:mainfrom
harsohailB:feature/1794

Conversation

@harsohailB
Copy link
Copy Markdown
Collaborator

@harsohailB harsohailB commented Jun 19, 2022

What github issue is this PR for, if any?

Resolves #1794

What changed, and why?

  • Updated send_court_report_reminder method in Volunteer model to send SMS along with trigger the existing mailer
  • Wrote CourtReportDueSmsReminderService class to send SMS regarding the court report reminder

How will this affect user permissions?

  • Volunteer permissions: N/A
  • Supervisor permissions: N/A
  • Admin permissions: N/A

How is this tested? (please write tests!) 💖💪

  • Wrote tests for CourtReportDueSmsReminderService class
  • Wrote additional tests for Volunteer model due to the change in send_court_report_reminder method

Screenshots please :)

IMG_3355

@harsohailB harsohailB marked this pull request as ready for review June 26, 2022 01:22
Copy link
Copy Markdown
Collaborator

@compwron compwron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@compwron compwron merged commit 1c47108 into rubyforgood:main Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ruby Touches Ruby code 🧪 Tests Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

volunteer receives SMS reminder to submit court report

2 participants