feature #3616 - "Set your account" password link in SMS activation messages#3700
Merged
Conversation
…with short links provided
…d short links in SMS
xihai01
added
ruby
compwron
reviewed
Jun 26, 2022
| helpers/contact_types_helper.rb | ||
| helpers/date_helper.rb | ||
| helpers/template_helper.rb | ||
| helpers/api_base_helper.rb |
Collaborator
There was a problem hiding this comment.
Please write tests for code instead of ignoring them
compwron
reviewed
Jun 26, 2022
| def handle_short_url(url_list) | ||
| hash_of_short_urls = {} | ||
| url_list.each_with_index { |val, index| | ||
| # call short io service to shorten url |
compwron
approved these changes
Jun 26, 2022
Collaborator
|
safe to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #3616
A set up password link is now sent with the account creation SMS. In addition, this link and the "/users/edit" link to change SMS settings are shortened using short.io service.
Note: Short io credentials do not exist in production env yet, so the SMS links aren't sent. In cases where such as these when there are issues with short io API itself, a default msg is sent instead as shown in screenshot
What changed, and why?
How is this tested? (please write tests!) 💖💪
Screenshots please :)
SMS when short link service has issues
coming soon
Feelings gif (optional)
coming soon
Feedback please? (optional)
We are very interested in your feedback! Please give us some :) https://forms.gle/1D5ACNgTs2u9gSdh9