Feature/6210 - Endpoint API remember_me option#6263
Merged
Conversation
JustinTan-1
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
github-actions
Bot
added
ruby
xihai01
reviewed
Mar 18, 2025
| end | ||
| end | ||
|
|
||
| describe "#generate_refresh_token_with_rememberme" do |
compwron
approved these changes
Mar 20, 2025
Collaborator
compwron
left a comment
compwron
left a comment
There was a problem hiding this comment.
seems harmless. Agreed that there is a nit in a test name but that is not a merge blocker. Do fix it in a followup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #6210
What changed, and why?
Add remember_me parameter to API endpoint to update refresh token expiry to 1 year.
Why?
Users have the option for the refresh token to expire after 1 yr instead of 30 days for extended sessions.
How is this tested? (please write tests!) 💖💪
2 tests for both return_new_refresh_token(true) and return_new_refresh_token(false) - spec/models/api_credential_spec.rb
Tested API endpoint with curl.
Screenshots please :)