Upgrade Rails from 7.2 to 8.0#6955
Conversation
github-actions
Bot
added
🧪 Tests
|
cooollll :) |
This extra require was added on the latest rails upgrade but it's not necessary anymore.
stefannibrasil
force-pushed
the
upgrade-to-rails-8.0
branch
from
4d12204 to
c5af932
Compare
stefannibrasil
force-pushed
the
upgrade-to-rails-8.0
branch
from
5eb704c to
d37e734
Compare
|
|
||
| foreman start -f Procfile.dev "$@" | ||
| #!/usr/bin/env ruby | ||
| exec "./bin/rails", "server", *ARGV |
There was a problem hiding this comment.
I tested things locally and this seems fine. Could someone try it out and see if it's best to keep the previous changes?
| # If set to `:zone`, `to_time` methods will use the timezone of their receivers. | ||
| # If set to `:offset`, `to_time` methods will use the UTC offset. | ||
| # If `false`, `to_time` methods will convert to the local system UTC offset instead. | ||
| #++ |
There was a problem hiding this comment.
The new defaults look okay to be enabled altogether...
| end | ||
| end | ||
| resources :reimbursements, only: %i[index change_complete_status], concerns: %i[with_datatable] do | ||
| resources :reimbursements, only: %i[index], concerns: %i[with_datatable] do |
There was a problem hiding this comment.
I tested the removed routes and they work as expected.
| @@ -1,6 +1,4 @@ | |||
| require "rails_helper" | |||
| # require "contact_type_group" | |||
There was a problem hiding this comment.
This was left here from the previous upgrade, but it's not necessary anymore.
| it "raises RoutingError if no step in url" do | ||
| expect { patch "/case_contacts/#{case_contact.id}/form", params: {case_contact: attributes} } | ||
| .to raise_error(ActionController::RoutingError) | ||
| it "responds with 404 if no step in url" do |
There was a problem hiding this comment.
I couldn't find out exactly where this changed in the release notes for this Rails version but I imagine it's a good change since it shows the new 404 page instead of raising a server error.
stefannibrasil
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
|
@compwron could you test this branch locally and in staging as well? I want to make sure I am not introducing anything that I couldn't test locally. Thanks! |
|
very cool, will do |
2 participants
What github issue is this PR for, if any?
Closes #6925
What changed, and why?
Rails 8.0 was released in late 2024 and brings Solid Queue / Solid Cache / Solid Cable as defaults, Propshaft, Kamal 2, Authentication generator, and a number of framework deprecations.
Most notable changes:
onlyandexceptfor non-RESTful routes: c64228aconfig/environmentswith the generated files as much as possibleconfig/initializers/new_framework_defaults_8_0.rblook okay to be enabled altogether but if you prefer to enable them individually, let me know.How is this tested? (please write rspec and jest tests!) 💖💪
Followups
config.load_defaultsto 8.0. It should fix this deprecation warning: "DEPRECATION WARNING:to_timewill always preserve the full timezone rather than offset of the receiver in Rails 8.1. To opt in to the new behavior, setconfig.active_support.to_time_preserves_timezone = :zone. (called from <top (required)> at /home/runner/work/casa/casa/config/environment.rb:5)"Questions
Is it possible to test this on staging/QA first? Please try this out locally and let me know if you run into any issues.