Court report submission status#912
Conversation
compwron
left a comment
There was a problem hiding this comment.
It looks good and I love the tests!
In general, avoid putting a big linter changeset in the same PR as non-lint work because it makes the PR difficult to review, especially if there's not a separate build for the changes-without-lint.
I made a copy of your branch without linting at https://github.com/rubyforgood/casa/pull/913/files to see the build pass. When that passes, I'll merge this PR, since some lint is nice to have- in retrospect I should have run it before hacktober but we were still recovering from power week 😅
|
You are invited to the CASA asynchronous retrospective-and-futurespective! Please take a look at https://bit.ly/casaretro (no login required) and add at least one note! Even if it's just "I was here and you are cool" or "omg y'all why do you keep messaging me" we want to hear it. <3
|
What github issue is this PR for, if any?
Resolves #882
What changed, and why?
On the CASA Case Details view there is a line that reads:
Court Report Submission: Not SubmittedIFCourse Report Submittedis NOT checked on the CASA Case edit pageor
Court Report Submission: SubmittedIFCourse Report Submittedis checked on the CASA Case edit pageHow will this affect user permissions?
How is this tested? (please write tests!) 💖💪
CasaCaseDecoratormethods don't have tests yet)volunteer_edits_a_case_spec.rbandsupervisor_edits_a_case_spec.rb(note: there seems to be a hold on theadmin_edits_a_case_spec.rbdue to a TravisCI issue so I didn't add to that test)Screenshots please :)
Other Notes
Feelings gif (optional)
What gif best describes your feeling working on this issue? https://giphy.com/

How to embed: