Skip to content

add route "Generate Court Report" to sidebar#992

Merged
compwron merged 8 commits into
rubyforgood:masterfrom
erik-trantt:923_add_route_generate_court_report
Oct 6, 2020
Merged

add route "Generate Court Report" to sidebar#992
compwron merged 8 commits into
rubyforgood:masterfrom
erik-trantt:923_add_route_generate_court_report

Conversation

@erik-trantt

@erik-trantt erik-trantt commented Oct 6, 2020

Copy link
Copy Markdown
Collaborator

What github issue is this PR for, if any?

Resolves #923

What changed, and why?

How will this affect user permissions?

N/A
Currently, all users can see visit the link and see the form.

How is this tested? (please write tests!) 💖💪

  • 1 test to check if link 'Generate Court Report' on sidebar is generated
    • spec/views/layouts/sidebar.html.erb_spec.rb
  • Tests to check if the page loads and the form elements (case selection & buttons) are present
    • app/views/case_court_reports/index.html.erb

Screenshots please :)

image
image
image

@erik-trantt erik-trantt changed the title 923 add route generate court report add route "Generate Court Report" to sidebar Oct 6, 2020
<div class="card-body">
<h5 class="card-title"><strong>Generate Court Report</strong></h5>
<p class="card-text">
The Court Report is pre-filled with information of your case. You can select among currently active cases assigned to you. The document is in Microsoft Word format (.dox).

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is .dox correct? I would expect .doc or .docx but I might be out of touch with windows

"information of your case" sounds funny - maybe "information for your case" instead?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@compwron You're right. It's a typo. The correct type is .docx.
I'll also change the wordings to "information for your case".

@compwron

compwron commented Oct 6, 2020

Copy link
Copy Markdown
Collaborator

Looking good! I see that this is still in "draft" state so I won't review it yet :)

@erik-trantt erik-trantt marked this pull request as ready for review October 6, 2020 23:15
@erik-trantt

Copy link
Copy Markdown
Collaborator Author

The commit was in CI build queue last night, so I waited till it finished to "open" the PR. Is it okay to open while CI build hasnt finished yet?

Looking good! I see that this is still in "draft" state so I won't review it yet :)

@compwron

compwron commented Oct 6, 2020

Copy link
Copy Markdown
Collaborator

The commit was in CI build queue last night, so I waited till it finished to "open" the PR. Is it okay to open while CI build hasnt finished yet?

Looking good! I see that this is still in "draft" state so I won't review it yet :)

@erik-trantt it is ok to open the PR without a green build on this repo. :)

@compwron compwron left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@compwron compwron merged commit 3276056 into rubyforgood:master Oct 6, 2020
@erik-trantt

Copy link
Copy Markdown
Collaborator Author

@compwron Thanks for the clarification 👍

@erik-trantt erik-trantt added hacktoberfest-accepted Accepted for Hacktoberfest and removed zzz_archived: 🧐 Status: Ready for Review PR ready for review labels Oct 7, 2020
@Zrrrpy Zrrrpy added the working-in-qa Tested and working in QA label Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Accepted for Hacktoberfest working-in-qa Tested and working in QA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add route to "Generate Court Report" to sidebar

3 participants