update default text of distribution email

[cielf]

Summary

The default text of the distribution email is inaccurate in some cases. Update it appropriately

Why

Could cause confusion

Details

To see the distribution email, on your local: sign in as org_Admin1@example.com. Then click Distributions, then click the "New Distribution" button.
Fill in the form minimally -- choose a storage location, a partner, and add one item, with a quantity.
Save , and confirm.

In a few minutes the email will appear in your browser.

There is a different issue dealing with the fact that the styling is not right on this.

the default behaviour of the distribution email says "your request has been approved", even if was a distribution that wasn't from a request.

Change that text to:

You have a new distribution from [bank name]. Please refer to the attachment for details,

Criteria for completion

• text changed
• it is possible that this will break an existing test that depends on the text. If it does, update that test.

[jasonwang7517]

I can take this!

[cielf]

It's yours!

[jasonwang7517]

Apologies for the confusion here but I seem to be getting a little lost in this codebase.

I tried following the instructions to create a new distribution and managed to step through the user flow but didn't see the email pop up.

Then I tried searching the code base for the phrase "your request has been approved" which brought me to this file but this seems a little different and it also doesn't get passed the bank name for use in the new text.

Am I looking in the wrong place here?

[cielf]

That looks like account requests rather than distributions...

Ah! The text is actually "Your essentials request has been approved." Which is found in partner_mailer.html.erb and partner_mailer.text.erb

[cielf]

And.... the partner on the distribution has to have "Do you want this partner to receive emails for distributions and reminders from the system?" set.

[jasonwang7517]

Awesome, thanks for the helpful context! This clears things up.