Fixing organization logo to work with ActiveStorage#460
Merged
seanmarcia merged 1 commit intoAug 12, 2018
Conversation
seanmarcia
requested changes
Aug 11, 2018
Member
seanmarcia
left a comment
seanmarcia
left a comment
There was a problem hiding this comment.
Looks great! I like moving the logic out of the helper into the organization.
I think the only thing that needs to be fixed is the one rubocop violation and this will be good to merge!
Member
|
Awesome! Thanks so much! |
armahillo
added
the
Repo First-timer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #459
Description
There was a bug where retrieving Organization logos were throwing errors because the
pathmethod did not exist on the new ActiveStorage::Blob object. The code has been refactored to retrieve the base diaper app logo if the organization does not have a logo and use the organization provided one otherwise.Type of change
How Has This Been Tested?
Added tests for the
logo_pathmethod on theorganization_spec.rb