Persist active storage uploads between deployments#475
Merged
Conversation
If the organization doesn't upload a logo, we should at least show some picture in it's place. This uses the stock diaperbase logo, which will show up on the org's homepage and pdf reports.
Active Storage is configured to store uploads under the `storage/` path in `Rails.root`. This folder needs to be symlinked from the capistrano `shared/` path so that way the same uploads can persist between deployments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1
Description
With the introduction of Active Storage in Rails 5, each new deployment was causing the images that have been uploaded to be lost. This fix ensures that uploads managed by Active Storage are persisted and carried along between deployments so logos don't need to be re-uploaded.
Type of change
How Has This Been Tested?
To test this, deploy a version of the site without using the fix (i.e., without the updated
linked_dirssetting in capistrano). This is actually easy to do since capistrano cues off of the code in your working directory rather than in the branch you are trying to deploy.On the remote server, you'll need to delete the
~/apps/diaper_base/shared/storagefolder, since it's existence in combination with the code in the branch fixes the issue.