Fixes #473 Refactor inventory changing methods mkd/amh#718

Merged

armahillo merged 34 commits into

mkd-refactor-inventory-changing-methods

May 18, 2019

Commits on Mar 31, 2019

review current models and refactor confusing sections

Michael Dworken
authored and
armahillo
committed
Improve increase_inventory decrease_inventory method

Michael Dworken
authored and
armahillo
committed
WIP - push up to diagnose failing tests

Michael Dworken
authored and
armahillo
committed
All specs pass again.
armahillo
committed
Rubocop fixes
armahillo
committed
Swaps out a few methods with the new methods. Created a test that spotlights an issue with how Adjustments are done now.
armahillo
committed
Distribution now uses increase_inventory, reclaim! has been renamed to just plain ol' destroy. Removed a few unnecessary database hits in a controller spec. Tests have not yet been resolved.
armahillo
committed
Wraps #create in a transaction. Extracts remove_inventory from Donation;
armahillo
committed

Commits on May 1, 2019

Simplify split_difference method
Michael Dworken
committed
Get tests passing re: adjustments
Michael Dworken
committed
Fix remaining spec failures; remove specs for implementation details no longer present
Michael Dworken
committed
Remove tests for methods no longer implemented
Michael Dworken
committed
Merge branch 'master' into mkd-refactor-inventory-changing-methods
Michael Dworken
committed
Fix rubocop violations
Michael Dworken
committed

Commits on May 12, 2019

Commits on May 15, 2019

Commits on May 18, 2019