Skip to content

update partner invitation form button with more context #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanmarcia merged 4 commits into from
Feb 23, 2019
Merged

update partner invitation form button with more context #720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b9b7ac
changes the text of the submit button
chaserx Feb 17, 2019
58ba7f3
changes the icon to use the envelope icon
chaserx Feb 17, 2019
d2b303e
updates partner spec with proper button text
chaserx Feb 18, 2019
02e4db8
guh. send not save. :facepalm:
chaserx Feb 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions app/views/partners/_form.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
<%= f.input_field :email, class: "form-control" %>
<% end %>

<%= submit_button %>
<% end %>

</div>
<%= submit_button({text: "Send Invitation", icon: "envelope"}) %>
<% end %>
</div>
8 changes: 4 additions & 4 deletions spec/features/partner_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@
visit url_prefix + "/partners/new"
fill_in "Name", with: "Frank"
fill_in "E-mail", with: "frank@frank.com"
click_button "Save"
click_button "Send Invitation"

expect(page.find(".alert")).to have_content "added"
end

scenario "User creates a new partner with empty name" do
visit url_prefix + "/partners/new"
click_button "Save"
click_button "Send Invitation"

expect(page.find(".alert")).to have_content "didn't work"
end
Expand All @@ -38,7 +38,7 @@
partner = create(:partner, name: "Frank")
visit url_prefix + "/partners/#{partner.id}/edit"
fill_in "Name", with: "Franklin"
click_button "Save"
click_button "Send Invitation"

expect(page.find(".alert")).to have_content "updated"
partner.reload
Expand All @@ -49,7 +49,7 @@
partner = create(:partner, name: "Frank")
visit url_prefix + "/partners/#{partner.id}/edit"
fill_in "Name", with: ""
click_button "Save"
click_button "Send Invitation"

expect(page.find(".alert")).to have_content "didn't work"
end
Expand Down