Add barcode scanning#787
Closed
amycommits wants to merge 7 commits into
Closed
Conversation
added 2 commits
March 31, 2019 14:15
boscomonkey
approved these changes
Apr 1, 2019
Collaborator
boscomonkey
left a comment
boscomonkey
left a comment
There was a problem hiding this comment.
I'm a little leery of scanS**t - don't want to offend newcomers to the project.
Collaborator
|
@duaimei It looks like there are 6 failing specs that are close-enough-related (eg. they deal with barcode scanning) that I think they may be legit failures; either broken behavior or bad test config -- do you have the available time to review these? LMK :) |
Collaborator
Author
|
this branch is now defunct. Look to barcode-scanning-feature |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1
Description
Type of change
How Has This Been Tested?
Screenshots