Skip to content

Add tag cognates #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dcollie2 merged 18 commits into from
Apr 12, 2025
Merged

Add tag cognates #133

dcollie2 merged 18 commits into from
Apr 12, 2025

Conversation

@hernanvicente
Copy link
Collaborator

@hernanvicente hernanvicente commented Mar 29, 2025 •
edited
Loading

What Issue Does This PR Cover, If Any?

Resolves #22 and #23

What Changed? And Why Did It Change?

  • Tags have cognates
  • CRUD for tags admin UI
  • New API scope for tags endpoint
  • Topic search includes the option to filter by tags
  • Flash elements are shown as part of the application layout

How Has This Been Tested?

  • Specs for the controller are in place
  • Unit tests for the TagCognate model are in place
  • System tests to verify the topic with associated tags on creation
  • System tests for tagging topics

Please Provide Screenshots

tags_with_cognates_edition.mov
topic_tags_filter.mov
tag_delete_confirmation.mov

Additional Comments

@hernanvicente hernanvicente linked an issue Mar 29, 2025 that may be closed by this pull request
Tag Cognates #22
Closed
9 tasks
@hernanvicente hernanvicente force-pushed the 22-tag-cognates branch 3 times, most recently from f0fda8f to 5ab30c3 Compare March 29, 2025 17:12
@hernanvicente hernanvicente force-pushed the 22-tag-cognates branch 5 times, most recently from 104d8cc to 15ce449 Compare April 9, 2025 19:13
@hernanvicente hernanvicente marked this pull request as ready for review April 10, 2025 16:34
@hernanvicente hernanvicente linked an issue Apr 11, 2025 that may be closed by this pull request
Tag Management Interface #23
Closed
6 tasks
@hernanvicente hernanvicente self-assigned this Apr 11, 2025
@hernanvicente hernanvicente added the enhancement New feature or request label Apr 11, 2025
@hernanvicente hernanvicente added this to the Tagging Works milestone Apr 11, 2025
This was referenced Apr 12, 2025
Closed
Open
dcollie2
dcollie2 approved these changes Apr 12, 2025
View reviewed changes
Copy link
Collaborator

@dcollie2 dcollie2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for picking up the flash stuff as well.

@dcollie2 dcollie2 merged commit 767eb31 into main Apr 12, 2025
4 checks passed
@dcollie2 dcollie2 deleted the 22-tag-cognates branch April 12, 2025 16:22
@Oli0li Oli0li mentioned this pull request Jul 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcollie2 dcollie2 dcollie2 approved these changes

@seanmarcia seanmarcia Awaiting requested review from seanmarcia

Assignees

@hernanvicente hernanvicente

Labels

enhancement New feature or request

Projects

None yet

Milestone

Tagging Works

Development

Successfully merging this pull request may close these issues.

Tag Management Interface Tag Cognates

3 participants

@hernanvicente @dcollie2