Add var step

[anasinnyk]

We want to share variables between steps.
Usage:

workflows:
  default:
    plan:
      steps:
      - env:
           name: test
           value: 123 # if setting statically
           command: echo 123 # if setting dynamically
      - run: echo $test
      - init
      - plan

fixed issue #370

[codecov]

Codecov Report

Merging #656 into master will increase coverage by 0.32%.
The diff coverage is 97.8%.

@@            Coverage Diff             @@
##           master     #656      +/-   ##
==========================================
+ Coverage   72.25%   72.57%   +0.32%     
==========================================
  Files          62       63       +1     
  Lines        4728     4792      +64     
==========================================
+ Hits         3416     3478      +62     
- Misses       1057     1058       +1     
- Partials      255      256       +1

Impacted Files	Coverage Δ
server/events/yaml/valid/repo_cfg.go	19.04% <ø> (ø)	⬆️
server/events/runtime/runtime.go	78.94% <ø> (ø)	⬆️
server/events/runtime/init_step_runner.go	83.33% <100%> (ø)	⬆️
server/server.go	64.47% <100%> (+0.47%)	⬆️
server/events/runtime/run_step_runner.go	90.47% <100%> (+0.47%)	⬆️
server/events/runtime/plan_step_runner.go	87.2% <100%> (ø)	⬆️
server/events/runtime/env_step_runner.go	100% <100%> (ø)
server/events/runtime/apply_step_runner.go	85.98% <100%> (ø)	⬆️
server/events/project_command_runner.go	74.33% <100%> (+1.43%)	⬆️
server/events/yaml/raw/step.go	93.44% <100%> (+2.74%)	⬆️
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ebebe5...2a55a4f. Read the comment docs.

[anasinnyk]

@lkysow coverage fixed

[lkysow]

Hi Andrii,
Sorry for the delay and thanks for all your hard work on this. I like this solution rather than using BASH_ENV.

At a high level I think the schema should be:

steps:
- env:
    name: NAME
    value: hardcoded-value
    command: echo dynamic-value

So

1. Change var => env
2. Add key value that allows setting the env var directly

I haven't looked at all the other code very hard but it looks like you're taking the right direction.
I noticed that all the mocks have been updated. Did you need to upgrade pegomock? If so, I'd like to do that myself in a separate PR. What version are you using?

[anasinnyk]

@lkysow thanks for the review. I changed your request. I just want to fix tests and cover new functionality and I use 2.5.0 version of pegomock.

Can you answer to my question about ctx.Env. If I should use local variable should I pass it to every setpRunner? Thanks

[lkysow]

I'll try upgrading pegomock to 2.5 and that should make this PR much easier to review

[lkysow]

master now has pegomock 2.5 so if you rebase you should have a much smaller diff :)

[anasinnyk]

I rebased master.

[anasinnyk]

I tried to fix tests right now.

[anasinnyk]

@lkysow I fixed test, but coverage is down :(

[anasinnyk]

@lkysow all done. Ready for new review.

[k-k]

@lkysow Anything left outstanding on this (outside of those conflicts)? I'd love to be able to use this.

[lkysow]

@lkysow Anything left outstanding on this (outside of those conflicts)? I'd love to be able to use this.

It's looking good, I just need time to a thorough review.

[anasinnyk]

@lkysow conflicts resolved

[lkysow]

Hi @anasinnyk,
I've merged your changes in #751 🎉

One thing that's missing though is the documentation. I thought I remember you writing it but I can't find it in the diff. Can you find it in your commits and submit a new PR?

I'm going to close this since the code is now in master.