Update qol-interfaces #10084
Open
Update qol-interfaces #10084
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riktenx suggest i find a better way to have a shared reposition code, this has been completed. Refactored overlay code into MoveableInterfaceOverlay base class Fixed transparency not resetting on plugin disable (sometimes), should work 100% now. Added BSD 2-Clause copyright headers - as required. Added Collection log "Unlock Hint" right-click option - Gives droprate & basic hint on where to get. Added Inventory value overlay - Simple moveable overlay that tells you based on GE value, how much is in your inventory.
Contributor
Author
|
Am I missing a step on updating plugins? What I'm currently doing is going to the plugin hub, going to my plugin and editing the "commit=" to my new commit., then submitting the PR this commit page. |
Contributor
|
Your repo hasn't had any commits in 4 days https://github.com/Col-Log/QOL-Interface/commits/main/ |
Contributor
Author
My bad! I committed the changes, should be there now. Is there a way to re-run the job or do I need to make a new PR? Commit hash is the same |
|
Internal use only: Reviewer details Maintainer details |
Member
|
I reran the workflow. In the future as well please do not close/open PRs, just push changes to your existing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Riktenx suggest i find a better way to have a shared reposition code, this has been completed.