Allow users to turn off in-place update for specific Expects - #22
Closed
ecstatic-morse wants to merge 1 commit into
Closed
Allow users to turn off in-place update for specific Expects#22ecstatic-morse wants to merge 1 commit into
Expects#22ecstatic-morse wants to merge 1 commit into
Conversation
Contributor
Author
|
Ended up not using this in rust-lang/chalk#744. It might still be nice to have, though. If not, feel free to close this. |
Contributor
|
Yeah, I think this could be useful, but one of the general design guidelines for expect-test is to do as little as possible, so let's wait until this has a significant use-case! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rust-lang/chalk#744 relies on this for now to avoid sweeping changes to the existing
test!macro. If this feature isn't desirable, I can change the approach, but it seems generally useful.