Fix Mnemonic documentation for supported wordcounts - #30
Merged
Conversation
tcharding
approved these changes
Oct 26, 2022
This Display description of the BadWordCount variant incorrectly complained stated that the word count is not a multiple of 6. The correct criteria for valid word counts is now that it must be a multiple of 3 between 12 and 24 inclusive, so the Display impl is fixed to be more precise.
pezcore
force-pushed
the
docfix/num-words
branch
from
January 28, 2023 21:28
44fa584 to
593f476
Compare
Collaborator
|
ACK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for additional word counts (specifically 15 and 21) was added in #18, but the documentation and the
Displayimpl forError::BadWordCountwas not updated to reflect this. This PR updates these to reflect the recent support for 15- and 21-word mnemonics.