Various improvements

[ayrat555]

• fix clippy warnings

[ayrat555]

@apoelstra @stevenroose hey. can you please review this pr?

the main change in this pr is all_words function. currently there is no way to get a list of words

[tcharding]

@apoelstra isn't involved in this crate, Steven is out of action right now, I can take a look for you though :)

[tcharding]

Can you put the clippy fixes in a separate commit please and the "add words" stuff in a commit on its own. Will make it much easier to review since I'm not super familiar with this code. FYI don't hold your breath for this to get merged any time soon, movement on this crate is a bit slow at the moment I'm afraid. We are doing our best :)

[ayrat555]

@tcharding done!

[tcharding]

Woops, somehow when I did the original review these two comments didn't get posted. The rest looks good to me.

[tcharding]

This is the MSRV, can't change this version. You made me realize that I missed updating it in #26

[tcharding]

Doesn't work with the current (or upcoming MSRV) I'm afraid.

[tcharding]

If you remove the edition 2021 change and the toolchain version then it should be good to go!

[tcharding]

Can you squash the last commit please? That way there are no changes later in the series of patches that change something in an earlier patch. Makes review easier for the next guy. Thanks

[tcharding]

You'll need to amend the PR description too :)

[ayrat555]

@tcharding addressed your comments.

if Steven is out of action, maybe he can give the ownership to someone else?

[tcharding]

Nah, we'll wait for him. Its open source, you can always fork it if you want to go a different direction.

[stevenroose]

The versioning part of this is handled in another MR and the all_words function seems to be identical to .language().word_list(), when word_list will be exposed in v1.1.0, see #40.

[ayrat555]

@stevenroose I removed this funciton

[tcharding]

This PR is only clippy changes now, perhaps #27 is better for that. @ayrat555 can you close if you are ok with waiting for #27 to go in?

[stevenroose]

Everything in this MR merged in some form or another except #27 indeed. Closing.