Make unicode normalization optional - #85
Closed
elsirion wants to merge 1 commit into
Closed
Conversation
elsirion
force-pushed
the
2025-05-normalization
branch
from
May 26, 2025 23:33
e64a0d5 to
93330e9
Compare
elsirion
commented
May 26, 2025
Comment on lines
+22
to
+28
| chinese-simplified = [ "unicode-normalization" ] | ||
| chinese-traditional = [ "unicode-normalization" ] | ||
| czech = [] | ||
| french = [] | ||
| italian = [] | ||
| japanese = [] | ||
| korean = [] | ||
| japanese = [ "unicode-normalization" ] | ||
| korean = [ "unicode-normalization" ] |
Collaborator
Author
There was a problem hiding this comment.
Idk if that's the right way to go about it, but it seems reasonable to want UN if you are dealing with these languages. I can also make it an entirely optional feature, which is cleaner but imo risks misuse.
maan2003
reviewed
May 27, 2025
| rand = [ "crate_rand", "rand_core" ] | ||
| alloc = [ "unicode-normalization" ] | ||
| alloc = [] | ||
| unicode-normalization = [ "dep:unicode-normalization", "alloc" ] |
There was a problem hiding this comment.
@stevenroose What was the ancient Rust version we need to get it to work on? :D
There was a problem hiding this comment.
@elsirion I guess we don't really need to use dep: which is somehow recent addition.
And we can have unicode-normalization-std to avoid using ?.
Collaborator
Author
|
I didn't consider the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential solution for #28 (comment)
With default features this is the dependency tree now: