CI: Pin memchr - #597
Merged
Merged
Conversation
Recently `memchr` broke our MSRV by updating to edition 2021 in a patch version, pin it in CI for MSRV builds.
apoelstra
approved these changes
Sep 12, 2023
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
3d1793af95e58031b1c9f7490e26eafcc2128282 CI: Pin memchr (Tobin C. Harding)
Pull request description:
Recently `memchr` broke our MSRV by updating to edition 2021 in a patch version, pin it in CI for MSRV builds.
ACKs for top commit:
apoelstra:
ACK 3d1793af95e58031b1c9f7490e26eafcc2128282
Tree-SHA512: cb7c6876bcb0cd16deb29e34240b9628b5aad39eb7a6ca4943b8d01c2f03b324e6166fd63c628bf1acbd9db1be90e7924a25fd5d3ec0ab82aabce1b96429462b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently
memchrbroke our MSRV by updating to edition 2021 in a patch version, pin it in CI for MSRV builds.