Skip to content

CI: Pin syn to 2.0.32 - #598

Merged
apoelstra merged 1 commit into
rust-bitcoin:masterfrom
danielabrozzoni:ci/regex
Sep 15, 2023
Merged

CI: Pin syn to 2.0.32#598
apoelstra merged 1 commit into
rust-bitcoin:masterfrom
danielabrozzoni:ci/regex

Conversation

@danielabrozzoni

@danielabrozzoni danielabrozzoni commented Sep 15, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@danielabrozzoni
danielabrozzoni marked this pull request as draft September 15, 2023 14:36
@danielabrozzoni
CI: Pin syn to 2.0.32
3d5cf3b 
Recently syn 2.0.33 broke our MSRV by depending on proc-macro2 1.0.67
@danielabrozzoni danielabrozzoni changed the title CI: Pin regex CI: Pin syn to 2.0.32 Sep 15, 2023
@danielabrozzoni
danielabrozzoni marked this pull request as ready for review September 15, 2023 14:58
@danielabrozzoni danielabrozzoni mentioned this pull request Sep 15, 2023
Merged
@apoelstra

apoelstra commented Sep 15, 2023

Copy link
Copy Markdown
Member

I'm a little surprised that any syn 2.0.x works with 1.48.

The point of the existing serde pins is to keep syn at 1.x. I wonder if it would be possible to remove or relax those now?

@apoelstra

apoelstra commented Sep 15, 2023

Copy link
Copy Markdown
Member

My approach to this CI failure would be to look at whatever's depending on syn 2.x and downgrade that.

@apoelstra

apoelstra commented Sep 15, 2023

Copy link
Copy Markdown
Member

On second thought, I don't care enough about the detailed reasons for serde deps to be breaking our shit. We should drop serde_derive which should eliminate all the proc-macro nastiness and move on. Which is a bigger project and independent of this PR.

apoelstra
apoelstra approved these changes Sep 15, 2023
View reviewed changes

@apoelstra apoelstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3d5cf3b

@apoelstra
apoelstra merged commit ff99a1f into rust-bitcoin:master Sep 15, 2023
@yancyribbens

yancyribbens commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

@danielabrozzoni thanks for fixing this! I looked into fixing this but I didn't think to try syn 2.0.x. How did you decide which version of syn to use?

@yancyribbens yancyribbens mentioned this pull request Sep 22, 2023
Closed
@danielabrozzoni

danielabrozzoni commented Oct 9, 2023

Copy link
Copy Markdown
Contributor Author

@yancyribbens in this case I think I just looked at the compiler error and downgrade the syn dependency until it compiled. Generally, I think using cargo tree with the latest toolchain and using the output to figure out which of our dependencies is importing the broken dependency and pinning that is a better approach, as Andrew suggested above.

heap-coder added a commit to heap-coder/rust-miniscript that referenced this pull request Sep 27, 2025
@heap-coder
Merge rust-bitcoin/rust-miniscript#598: CI: Pin syn to 2.0.32
4a87f23 
3d5cf3bb01c914438e3e79e7cb27672c92b82dfe CI: Pin syn to 2.0.32 (Daniela Brozzoni)

Pull request description:

ACKs for top commit:
  apoelstra:
    ACK 3d5cf3bb01c914438e3e79e7cb27672c92b82dfe

Tree-SHA512: d61a303bef9d14f9856134929b96be633c35cc506f377a704f1dd69b35e9a351a8537c903e0a6cefa0f51dae9534db91a94a993422442395ed31af83897a0896
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoelstra apoelstra apoelstra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danielabrozzoni @apoelstra @yancyribbens