Skip to content

PtyProcess: add NO_CTTY flag #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
petreeftime wants to merge 6 commits into from
Closed

PtyProcess: add NO_CTTY flag #101

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2fac169
update to swatinem/rust-cache@v2
petreeftime Apr 23, 2023
1f75263
PtyProcess: add NO_CTTY flag
petreeftime Apr 23, 2023
ab53025
make new terminal controlling terminal
petreeftime Apr 23, 2023
2e292c1
try wait echo
petreeftime Apr 23, 2023
7156464
wait after send
petreeftime Apr 23, 2023
62b314c
remove echo on master_fd
petreeftime Apr 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove echo on master_fd 
Signed-off-by: Petre Eftime <petre.eftime@gmail.com>
  • Loading branch information
@petreeftime
petreeftime committed Apr 23, 2023
commit 62b314cbd697580d03b08402b39818ee3ad4976a
5 changes: 5 additions & 0 deletions src/process.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,11 @@ impl PtyProcess {
// on Linux this is the libc function, on OSX this is our implementation of ptsname_r
let slave_name = ptsname_r(&master_fd)?;

// set echo off
let mut flags = termios::tcgetattr(master_fd.as_raw_fd())?;
flags.local_flags.remove(termios::LocalFlags::ECHO);
termios::tcsetattr(master_fd.as_raw_fd(), termios::SetArg::TCSANOW, &flags)?;

match unsafe { fork()? } {
ForkResult::Child => {
// Avoid leaking master fd
Expand Down