Skip to content
This repository was archived by the owner on Dec 2, 2020. It is now read-only.

Code formatting#54

Closed
eldruin wants to merge 2 commits into
rust-embedded:masterfrom
eldruin:fmt
Closed

Code formatting#54
eldruin wants to merge 2 commits into
rust-embedded:masterfrom
eldruin:fmt

Conversation

@eldruin

@eldruin eldruin commented Apr 23, 2020

Copy link
Copy Markdown
Member

No description provided.

@eldruin eldruin requested a review from a team as a code owner April 23, 2020 10:50
@rust-highfive

Copy link
Copy Markdown

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thejpster (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@thejpster

Copy link
Copy Markdown

Looks good, but I wonder if we should enforce this in CI to avoid subsequent PRs diverging from the rustfmt standard.

@eldruin

eldruin commented May 6, 2020

Copy link
Copy Markdown
Member Author

@thejpster Sure thing. I added the check now.

@therealprof

Copy link
Copy Markdown
Contributor

We're planning to use more GitHub Actions for CI and these kind of checks. Maybe it would make more sense to go straight to GHA instead of using Travis for a short bit?

Adding it should be as simple as copying these two workflows: https://github.com/rust-embedded/svd2rust/tree/master/.github/workflows

@therealprof

Copy link
Copy Markdown
Contributor

Well, wrong example. The CI workflow is the wrong one. ;) This should hit the spot better: https://github.com/stm32-rs/stm32f1xx-hal/blob/master/.github/workflows/rustfmt.yml

@eldruin

eldruin commented May 6, 2020

Copy link
Copy Markdown
Member Author

@therealprof Sure. GHA are quite nice. I added only the formatting check for now. Building CI could be done in a separate PR.

@therealprof therealprof left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@therealprof

Copy link
Copy Markdown
Contributor

bors r+

@therealprof

Copy link
Copy Markdown
Contributor

Hm, bors crashed on this. Let's try again.

bors merge

@eldruin

eldruin commented May 12, 2020

Copy link
Copy Markdown
Member Author

@therealprof bors has been having a couple rough days. Could you try again?

@korken89

Copy link
Copy Markdown
Contributor

bors retry

@korken89

Copy link
Copy Markdown
Contributor

bors cancel

@korken89 korken89 closed this May 16, 2020
@korken89 korken89 reopened this May 16, 2020
@korken89

Copy link
Copy Markdown
Contributor

bors r+

@adamgreig

adamgreig commented Oct 14, 2020

Copy link
Copy Markdown
Member

Thanks for the PR, and sorry bors never quite managed to merge it... we've now moved this crate to the cortex-m repository. We could consider adding rustfmt over there to the whole repository, but I'm closing the PR here.

@adamgreig adamgreig closed this Oct 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants