Make digital traits fallible#105
Conversation
eldruin
requested review from
a team,
ilya-epifanov and
thejpster
as code owners
ryankurte
left a comment
ryankurte
left a comment
There was a problem hiding this comment.
looks great to me, thanks @eldruin! (and sorry for all the sidetracking)
cc. @hannobraun
hannobraun
left a comment
hannobraun
left a comment
There was a problem hiding this comment.
Looks good to me! Thank you @eldruin for all your great work, and sorry for the back and forth. This is a hard project to maintain and contribute to :)
|
I'm fine with merging this, but there's discussion in #92 about releasing a last 0.2.x release before merging breaking changes. |
hannobraun
added
S-waiting-on-team
hannobraun
left a comment
hannobraun
left a comment
There was a problem hiding this comment.
Sorry, @eldruin, there's going to be more back and forth. My proposal to make a clean break here was possibly wrong. At the very least, it was premature to assume this discussion was resolved and we can go ahead here. I've become convinced we need to block this pull request until we've decided on a transition strategy in #100, or at least until we've given everyone more time to comment on my proposal to make a clean breaking change.
More context: #92 (comment)
3 participants
This makes the digital traits fallible as discussed in #97, #95, #100 and #41 implemented as a clean break.