Skip to content

Use nb 1.0#234

Merged
bors[bot] merged 1 commit into
rust-embedded:masterfrom
eldruin:use-nb-1.0
Jul 13, 2020
Merged

Use nb 1.0#234
bors[bot] merged 1 commit into
rust-embedded:masterfrom
eldruin:use-nb-1.0

Conversation

@eldruin

@eldruin eldruin commented Jul 10, 2020

Copy link
Copy Markdown
Member

🎉

@rust-highfive

Copy link
Copy Markdown

r? @thejpster

(rust_highfive has picked a reviewer for you, use r? to override)

@ryankurte

Copy link
Copy Markdown
Contributor

🎉

is this worth an entry in the changelog? otherwise lgtm

@eldruin

eldruin commented Jul 13, 2020

Copy link
Copy Markdown
Member Author

Sure. I added an entry now.

@ryankurte ryankurte left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

bors r+

bors Bot added a commit that referenced this pull request Jul 13, 2020
234: Use nb 1.0 r=ryankurte a=eldruin

🎉 

Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
@bors

bors Bot commented Jul 13, 2020

Copy link
Copy Markdown
Contributor

Timed out.

@bors

bors Bot commented Jul 13, 2020

Copy link
Copy Markdown
Contributor

@bors bors Bot merged commit b46d300 into rust-embedded:master Jul 13, 2020
@eldruin eldruin deleted the use-nb-1.0 branch July 13, 2020 08:21
@eldruin eldruin mentioned this pull request Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Review is incomplete T-hal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants