Skip to content

Fix code formatting + check it on bors#266

Merged
bors[bot] merged 2 commits into
rust-embedded:masterfrom
eldruin:fix-formatting
Mar 12, 2021
Merged

Fix code formatting + check it on bors#266
bors[bot] merged 2 commits into
rust-embedded:masterfrom
eldruin:fix-formatting

Conversation

@eldruin

@eldruin eldruin commented Mar 11, 2021

Copy link
Copy Markdown
Member

This was missed in #246.

@rust-highfive

Copy link
Copy Markdown

r? @ryankurte

(rust-highfive has picked a reviewer for you, use r? to override)

@eldruin

eldruin commented Mar 11, 2021

Copy link
Copy Markdown
Member Author

bors try

bors Bot added a commit that referenced this pull request Mar 11, 2021
therealprof
therealprof previously approved these changes Mar 11, 2021

@therealprof therealprof left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

bors r+

bors Bot added a commit that referenced this pull request Mar 11, 2021
266: Fix code formatting + check it on bors r=therealprof a=eldruin

This was missed in #246.

Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
@eldruin

eldruin commented Mar 11, 2021

Copy link
Copy Markdown
Member Author

bors r=therealprof

@bors

bors Bot commented Mar 11, 2021

Copy link
Copy Markdown
Contributor

Already running a review

@bors

bors Bot commented Mar 11, 2021

Copy link
Copy Markdown
Contributor

Timed out.

@bors

bors Bot commented Mar 11, 2021

Copy link
Copy Markdown
Contributor

try

Timed out.

@eldruin

eldruin commented Mar 11, 2021

Copy link
Copy Markdown
Member Author

bors r=therealprof

bors Bot added a commit that referenced this pull request Mar 11, 2021
266: Fix code formatting + check it on bors r=therealprof a=eldruin

This was missed in #246.

Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
@bors

bors Bot commented Mar 11, 2021

Copy link
Copy Markdown
Contributor

Canceled.

@eldruin

eldruin commented Mar 11, 2021

Copy link
Copy Markdown
Member Author

bors try

bors Bot added a commit that referenced this pull request Mar 11, 2021
@eldruin

eldruin commented Mar 12, 2021

Copy link
Copy Markdown
Member Author

bors try

@bors

bors Bot commented Mar 12, 2021

Copy link
Copy Markdown
Contributor

try

Already running a review

@eldruin

eldruin commented Mar 12, 2021

Copy link
Copy Markdown
Member Author

bors try

@bors

bors Bot commented Mar 12, 2021

Copy link
Copy Markdown
Contributor

try

Already running a review

@eldruin

eldruin commented Mar 12, 2021

Copy link
Copy Markdown
Member Author

Sorry for the back and forth. The bors requirements were not right.
Could you review this again @therealprof?

@bors

bors Bot commented Mar 12, 2021

Copy link
Copy Markdown
Contributor

try

Timed out.

@therealprof therealprof left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

bors r+

@bors

bors Bot commented Mar 12, 2021

Copy link
Copy Markdown
Contributor

@bors bors Bot merged commit 4221894 into rust-embedded:master Mar 12, 2021
@therealprof

Copy link
Copy Markdown
Contributor

Just for reference: I'm not super keen on the idea of making formatting checks mandatory. We had problems in the past when formatting rules changed (similar to clippy rules) and we should actually run CI on a schedule and not just on PRs (which should be fine since they should be up-to-date re formatting).

Here's to hope that Rust is not going to make a lot of tweaks to the formatting to not get back at us. 😅 Let's see how it goes.

@eldruin

eldruin commented Mar 12, 2021

Copy link
Copy Markdown
Member Author

True. clippy bit me all over the place with a rule I believe is not good and I am still not even done updating all my drivers to disregard it. fmt has been quite stable so far, but yeah, good point.

@eldruin eldruin deleted the fix-formatting branch March 12, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Review is incomplete T-hal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants