Remove RNG traits#291
Merged
Merged
Conversation
|
r? @ryankurte (rust-highfive has picked a reviewer for you, use r? to override) |
ryankurte
reviewed
Jul 5, 2021
| - Removed `prelude` to avoid method name conflicts between different flavors (blocking, nb) of the same trait. Traits must now be manually imported. | ||
|
|
||
| ### Removed | ||
| - Removed random number generation (`rng`) traits in favor of [rand_core](https://crates.io/crates/rand_core). |
Contributor
There was a problem hiding this comment.
probably out of scope but (and plausible we already have one) but, it could be neat to have a using rand section in one of our books we could direct people to?
Member
Author
There was a problem hiding this comment.
That is a good idea. We can then also add a reference to that in the migration guide.
I filed rust-embedded/rust-embedded.github.io#35
Member
Author
|
@ryankurte would you like to wait until the guide on how to implement the |
ryankurte
approved these changes
Jul 9, 2021
ryankurte
left a comment
ryankurte
left a comment
Contributor
There was a problem hiding this comment.
i don't really mind either way, seems fine to me
Member
Author
|
Ok let's get this merged then. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duplicate of #270 adapted to the current status.
The documentation about what happened to the traits will go into the migration guide. See: #284.
Closes #270
Closes #128