Fix serial doctest + require passing tests on bors#305
Merged
Conversation
|
r? @therealprof (rust-highfive has picked a reviewer for you, use r? to override) |
Contributor
|
Ah, #300 let to the example actually being build, which contains compiler errors. Sorry for the inconvenience 🙈 😀 |
therealprof
previously approved these changes
Aug 3, 2021
therealprof
left a comment
therealprof
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks.
bors r+
bors Bot
added a commit
that referenced
this pull request
Aug 3, 2021
305: Fix serial doctest + require passing tests on bors r=therealprof a=eldruin This escaped CI somehow in #300. Thanks to `@adamgreig` for his help in figuring this out. Now passing the tests is also a requirement for bors. Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
Contributor
|
Timed out. |
Contributor
|
bors retry |
bors Bot
added a commit
that referenced
this pull request
Aug 3, 2021
305: Fix serial doctest + require passing tests on bors r=therealprof a=eldruin This escaped CI somehow in #300. Thanks to `@adamgreig` for his help in figuring this out. Now passing the tests is also a requirement for bors. Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
adamgreig
reviewed
Aug 3, 2021
Co-authored-by: Adam Greig <adam@adamgreig.com>
Contributor
|
Canceled. |
therealprof
approved these changes
Aug 3, 2021
therealprof
left a comment
therealprof
left a comment
Contributor
There was a problem hiding this comment.
Let's try this then. ;)
bors r+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This escaped CI somehow in #300.
Thanks to @adamgreig for his help in figuring this out.
Now passing the tests is also a requirement for bors.