u8 as default SPI Word#321
Merged
Merged
Conversation
|
r? @ryankurte (rust-highfive has picked a reviewer for you, use r? to override) |
Sh3Rm4n
reviewed
Nov 3, 2021
Sh3Rm4n
left a comment
Sh3Rm4n
left a comment
Contributor
There was a problem hiding this comment.
I think this is a sensible default and may also be expanded to other traits, like the Serial traits?
Dirbaio
approved these changes
Nov 3, 2021
Dirbaio
left a comment
Dirbaio
left a comment
Member
There was a problem hiding this comment.
I like this! I can't think of any downside, and the vast majority of SPI uses are u8.
We should do the same for uart and other traits.
ryankurte
approved these changes
Nov 3, 2021
ryankurte
left a comment
ryankurte
left a comment
Contributor
There was a problem hiding this comment.
seems reasonable to me, any other opinions @rust-embedded/hal ?
Contributor
|
LGTM! |
eldruin
approved these changes
Nov 4, 2021
eldruin
left a comment
eldruin
left a comment
Member
There was a problem hiding this comment.
Looks good to me as well, thank you!
bors r+
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #320