Require all SPI and Serial word types to be Copy#326
Conversation
|
r? @ryankurte (rust-highfive has picked a reviewer for you, use r? to override) |
eldruin
left a comment
There was a problem hiding this comment.
Requiring Copy for word types seems fine to me.
I am not sure what the reason for the 'static bound was so I will leave that to @ryankurte
|
Perhaps we want to require |
|
i had to go digging [1, 2], it appears the justification was to separate the lifetime of the type
|
|
I decided to leave the |
eldruin
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
bors r+
The word type should always be a builtin integer (
u8,u16, etc) or a newtype to represent an integer with an unusual size, which will almost certainly beCopy.I also removed the
'staticbound from the spi transactional stuff because it appears to be unnecessarily now.