Add embedded-hal-async crate in subdirectory#342
Merged
Conversation
|
r? @ryankurte (rust-highfive has picked a reviewer for you, use r? to override) |
eldruin
force-pushed
the
add-embedded-hal-async
branch
from
bd0cc2b to
919b920
Compare
eldruin
force-pushed
the
add-embedded-hal-async
branch
from
919b920 to
d175998
Compare
Member
|
👍 👍 So are we merging this? Shall I split up #334 into several PRs on top of this? |
Member
This is the plan |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simpler version of #334 where an empty
embedded-hal-asynccrate is added inside a subfolder.I propose merging this and add all the traits and docs piece by piece so that they can be discussed comfortably.
The CI adaption went fine except for the changelog check, which cannot check that the changelog in the
embedded-hal-asyncsubfolder was touched.All credit for this idea goes to @Dirbaio !