async: add i2c#348
Merged
Merged
Conversation
|
r? @ryankurte (rust-highfive has picked a reviewer for you, use r? to override) |
eldruin
approved these changes
Jan 12, 2022
eldruin
left a comment
eldruin
left a comment
Member
There was a problem hiding this comment.
Seems straight-forward to me, thanks!
We could add an I2cIter trait in the future if there is a good use case.
bors r+
Contributor
|
👎 Rejected by too few approved reviews |
Member
|
What? I just approved this |
Contributor
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mirrors the blocking i2c trait (including the changes proposed in #339 ), except the following:
itermethods since they don't play well with DMA.