Skip to content

gpio: remove ToggleableOutputPin, move toggle() to StatefulOutputPin.#550

Merged
Dirbaio merged 1 commit into
rust-embedded:masterfrom
Dirbaio:gpio-no-toggleable
Dec 20, 2023
Merged

gpio: remove ToggleableOutputPin, move toggle() to StatefulOutputPin.#550
Dirbaio merged 1 commit into
rust-embedded:masterfrom
Dirbaio:gpio-no-toggleable

Conversation

@Dirbaio

@Dirbaio Dirbaio commented Dec 19, 2023

Copy link
Copy Markdown
Member

fixes #549

@Dirbaio Dirbaio requested a review from a team as a code owner December 19, 2023 19:55
@Dirbaio Dirbaio changed the title io: remove ToggleableOutputPin, move toggle() to StatefulOutputPin. gpio: remove ToggleableOutputPin, move toggle() to StatefulOutputPin. Dec 19, 2023

@eldruin eldruin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have read the discussion and agree with this change.
Thank you!

@Dirbaio Dirbaio added this pull request to the merge queue Dec 20, 2023
Merged via the queue into rust-embedded:master with commit 6c09acb Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ToggleableOutputPin feels redundant

2 participants