Make unused dependencies optional#118
Merged
Merged
Conversation
- No need to pull serialport-rs and embedded-hal-nb in projects that do not need serial functionality. Signed-off-by: Ayush Singh <ayush@beagleboard.org>
eldruin
reviewed
Feb 7, 2025
eldruin
left a comment
eldruin
left a comment
Member
There was a problem hiding this comment.
Sounds good to me, thanks!
Could you also add an entry to the changelog?
Ayush1325
force-pushed
the
serial-optional
branch
from
307f06d to
df3d5b3
Compare
- nix dependency is only directly used for i2c in this crate. Signed-off-by: Ayush Singh <ayush@beagleboard.org>
Signed-off-by: Ayush Singh <ayush@beagleboard.org>
Ayush1325
force-pushed
the
serial-optional
branch
from
df3d5b3 to
17b2457
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
default-featuresin most single peripheral examples.