Skip to content

Implementation of embedded_hal::digital::IoPin#60

Merged
bors[bot] merged 3 commits into
rust-embedded:masterfrom
MorganR:master
Oct 4, 2021
Merged

Implementation of embedded_hal::digital::IoPin#60
bors[bot] merged 3 commits into
rust-embedded:masterfrom
MorganR:master

Conversation

@MorganR

@MorganR MorganR commented Apr 25, 2021

Copy link
Copy Markdown
Contributor

This is just a draft, and is pending the PR merge of an IoPin implementation into embedded_hal.

I've verified it with a no-std DHT11 driver based on the IoPin PR.

@rust-highfive

Copy link
Copy Markdown

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nastevens (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Comment thread Cargo.toml Outdated
@MorganR

MorganR commented Apr 27, 2021

Copy link
Copy Markdown
Contributor Author

This has been updated to match the definition of IoPin as merged in embedded_hal PR 269.

@MorganR

MorganR commented May 16, 2021

Copy link
Copy Markdown
Contributor Author

Hey folks, I've added a commit to remove the try_ prefixes so this can build against the embedded-hal HEAD. Would you rather merge it like this, or wait until embedded-hal pushes the next alpha release?

@eldruin

eldruin commented May 17, 2021

Copy link
Copy Markdown
Member

Thanks! It would be better only to depend on released versions of embedded-hal.

@eldruin

eldruin commented Sep 28, 2021

Copy link
Copy Markdown
Member

@MorganR Could you update this PR now that I updated this repository to embedded-hal 1.0.0-alpha.5?

@MorganR

MorganR commented Oct 2, 2021

Copy link
Copy Markdown
Contributor Author

Absolutely, I'll update it by the end of the weekend

@MorganR MorganR marked this pull request as ready for review October 2, 2021 17:25
@MorganR MorganR requested a review from a team as a code owner October 2, 2021 17:25

@eldruin eldruin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!
bors r+

@bors

bors Bot commented Oct 4, 2021

Copy link
Copy Markdown
Contributor

@bors bors Bot merged commit 92960cc into rust-embedded:master Oct 4, 2021
@eldruin

eldruin commented Oct 7, 2021

Copy link
Copy Markdown
Member

@MorganR FYI this is published as part of the 0.4.0-alpha.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Review is incomplete T-embedded-linux

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants