Fix cargo doc --open on Windows#2780
Conversation
This fixes rust-lang#2446. Note that I have not built cargo with this change, but I have tested the functionality in isolation (on Windows 10). As to the issue itself, I don't know why the previous version didn't work, but `start` is redundant when `cmd /C` is used.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @wycats (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Fix `cargo doc --open` on Windows This fixes #2446. Note that I have not built cargo with this change, but I have tested the functionality in isolation (on Windows 10). As to the issue itself, I don't know why the previous version didn't work, but `start` is redundant when `cmd /C` is used.
|
☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
5 participants
This fixes #2446. Note that I have not built cargo with this change, but I have tested the functionality in isolation (on Windows 10).
As to the issue itself, I don't know why the previous version didn't work, but
startis redundant whencmd /Cis used.