More lowering improvements - #606
Merged
Merged
Conversation
detrumi
marked this pull request as ready for review
September 8, 2020 21:03
jackh726
requested changes
Sep 10, 2020
jackh726
left a comment
jackh726
left a comment
Member
There was a problem hiding this comment.
Some comments, but r=me after.
jackh726
approved these changes
Sep 11, 2020
| pub addl_variable_kinds: Vec<chalk_ir::VariableKind<ChalkIr>>, | ||
| } | ||
|
|
||
| pub enum TypeLookup<'k> { |
Member
There was a problem hiding this comment.
I would argue this isn't quite TypeLookup since Trait isn't a type, but eh. This is probably fine.
Member
|
@detrumi please r=jackh726 instead of merging directly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.