strip out references to rustdoc's custom favicon#330
strip out references to rustdoc's custom favicon#330QuietMisdreavus wants to merge 1 commit intorust-lang:masterfrom
Conversation
|
Alongside this, wouldn't it be simpler to generate crates with your own favicon? |
|
We don't currently have the option for the favicon URL to be set via a CLI argument. If we did that, then we could replace this PR with one that passed |
|
Another option is to change the web server to redirect all |
|
Well, that last solution sounds good! :) Meanwhile, I'll add an option to allow to pass a favicon through CLI if you want? |
|
I managed to get the |
2 participants
Starting in rust-lang/rust#57552, rustdoc started packaging in a default column logo and favicon. We started hosting the logo in #290, but ignored the favicon, since docs.rs has its own. However, since rustdoc includes a
<link rel="shortcut icon">tag in the<head>, this overrides the behavior of using/favicon.ico, and creates a lot of extra 404s as people try to access a favicon that isn't there. This PR strips out that favicon reference, which puts a favicon back into documentation pages again.(Note that this will also strip out custom favicons provided by crates, like the one used by Rocket. If desired, i could add in a different check that would only filter out ones rooted locally (path either begins with
/or..) which would allow custom favicons set by crates to still work.)