Skip to content

Add build date to dropdown#3376

Merged
GuillaumeGomez merged 5 commits into
rust-lang:mainfrom
darricheng:add-build-date-to-dropdown
Jun 19, 2026
Merged

Add build date to dropdown#3376
GuillaumeGomez merged 5 commits into
rust-lang:mainfrom
darricheng:add-build-date-to-dropdown

Conversation

@darricheng

@darricheng darricheng commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Addresses #1740.

Screenshot 2026-06-18 at 10 41 10 PM

Would adding a link to the builds page make sense?
E.g. https://docs.rs/crate/jiff/0.2.28/builds

@darricheng darricheng requested a review from a team as a code owner June 18, 2026 14:14
@github-actions github-actions Bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Jun 18, 2026
Comment thread crates/bin/docs_rs_web/templates/rustdoc/topbar.html Outdated
E.g. 12 June 2026
@GuillaumeGomez

Copy link
Copy Markdown
Member

Please update the screenshot now.

@darricheng

Copy link
Copy Markdown
Contributor Author

@GuillaumeGomez updated the PR description. The GUI test failed in the previous commit, which seems to be because we added a new row to that topbar section. I'm not familiar enough with the testing method though, e.g. what page the testing framework is using to run the tests. Is it just a matter of bumping the count from 3 to 4 in this case?

gui-tests/crate-topbar-dropdown-menu.goml

store-value: (crate_main_info_items, ".package-details-menu > ul > .pure-menu-item")
// There should be 3 items.
assert-count: (|crate_main_info_items|, 3)

@GuillaumeGomez

Copy link
Copy Markdown
Member

Ah yes, since you added a new row, you need to increase the number to 4. If you want more info about browser-ui-test (the framework we use for the GUI tests): https://github.com/GuillaumeGomez/browser-UI-test/blob/main/goml-script.md

@GuillaumeGomez

Copy link
Copy Markdown
Member

Thanks!

@GuillaumeGomez GuillaumeGomez enabled auto-merge (rebase) June 19, 2026 10:43
@GuillaumeGomez GuillaumeGomez merged commit ab56d03 into rust-lang:main Jun 19, 2026
12 checks passed
@github-actions github-actions Bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Jun 19, 2026
@darricheng darricheng deleted the add-build-date-to-dropdown branch June 19, 2026 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants