Skip to content

add #[derive(Debug)] to Matches struct; run cargo fmt; fix with clippy#77

Merged
KodrAus merged 1 commit into
rust-lang:masterfrom
Zaechus:master
Nov 26, 2018
Merged

add #[derive(Debug)] to Matches struct; run cargo fmt; fix with clippy#77
KodrAus merged 1 commit into
rust-lang:masterfrom
Zaechus:master

Conversation

@Zaechus

@Zaechus Zaechus commented Nov 26, 2018

Copy link
Copy Markdown
Contributor

I added the Debug implementation to the Matches struct and associated data types. I also took the liberty to format the code with rustfmt and fix some small clippy lints. The lint changes shouldn't affect the functionality at all.

Fixes #64

@KodrAus KodrAus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maxgy!

I gave this a quick scan through, and couldn't spot any cases where clippy might've lead us to make any breaking changes.

@KodrAus KodrAus merged commit 87e60a0 into rust-lang:master Nov 26, 2018
@Zaechus

Zaechus commented Nov 26, 2018

Copy link
Copy Markdown
Contributor Author

The clippy lints were only for changing things like
!a.is_none() to a.is_some() or
a.len() > 0 to !a.is_empty() or
Err(_) to _,
so the library should behave the same way.

@KodrAus KodrAus mentioned this pull request May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add #[derive(Debug)] to struct Matches?

2 participants