Rename the notbsd module to linux_like

[gnzlbg]

No description provided.

[rust-highfive]

@gnzlbg: no appropriate reviewer found, use r? to override

[gnzlbg]

@bors: r+

[bors]

📌 Commit 8f098a3 has been approved by gnzlbg

[bors]

⌛ Testing commit 8f098a3 with merge cf78b5d...

[bors]

💔 Test failed - checks-travis

[gnzlbg]

@bors: retry

[bors]

⌛ Testing commit 8f098a3 with merge ce7e3a7...

[bors]

☀️ Test successful - checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-travis, status-appveyor
Approved by: gnzlbg
Pushing ce7e3a7 to master...

[kleimkuhler]

@gnzlbg Hey I'm running into an error where notbsd::... is expected, but linux_like::... is found. I've replicated it in playground.

Any idea if this is an error in trying to make a SocketAddr or some version conflict?

Edit: I'm trying to make the SocketAddr here

pub struct SocketAddr {
    addr: libc::sockaddr_un,
    len: libc::socklen_t,
}

Edit 2: Sorry for the ping on this. I realize now I can't even make this type because the fields are private

[gnzlbg]

@kleimkuhler you should open an issue in rust-lang/rust since that looks like a bug in libstd.

Essentially, the types exposed by libc are not the same types exposed by libstd. Often, libstd has newtypes for them (e.g. pthread_t), but sometimes someone made a bug somewhere.

[gnzlbg]

Looking at the source, it appears that libstd does properly have a newtype here, the fields of that type are private, so you should never see a type error here, but a privacy error instead.

I think this is worth reporting as an error to the Rust compiler. The error message is confusing.

[gnzlbg]

I've reported it here: rust-lang/rust#64684

[kleimkuhler]

@gnzlbg Oh okay thanks for the explanation on that--and reporting it!