Add FreeBSD10 build job#1491
Conversation
|
@gnzlbg: no appropriate reviewer found, use r? to override |
gnzlbg
force-pushed
the
freebsd10
branch
2 times, most recently
from
efee8ae to
a82f231
Compare
asomers
left a comment
asomers
left a comment
There was a problem hiding this comment.
ppoll first appeared in FreeBSD 11, so we probably shouldn't define it when freebsd10 is set.
asomers
left a comment
asomers
left a comment
There was a problem hiding this comment.
Are you sure we need to do this? The FreeBSD 10 series is EOL.
| cfg.define("_WANT_FREEBSD11_STAT", None); | ||
| match freebsd_ver { | ||
| Some(10) => &mut cfg, | ||
| _ => cfg.define("_WANT_FREEBSD11_STAT", None), |
There was a problem hiding this comment.
You shouldn't need this symbol . This is only needed on 12+ to expose the backwards-compatible definition of struct stat under a different name, and libc doesn't appear to be doing anything with it.
| } | ||
|
|
||
| // FIXME: This constant has a different value in FreeBSD 10: | ||
| "RLIM_NLIMITS" if Some(10) == freebsd_ver => true, |
There was a problem hiding this comment.
This constant shouldn't even be defined by libc. I'm going to open a new PR to deprecate it.
|
☔ The latest upstream changes (presumably #1497) made this pull request unmergeable. Please resolve the merge conflicts. |
4 participants
No description provided.