linux: Add definitions for Multipath TCP#1902
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
george-hopkins
force-pushed
the
mptcp
branch
from
d669ba4 to
a6b676b
Compare
|
This is a breaking change and I think we should add a deprecation note to tell users that the value will be changed here. |
|
☔ The latest upstream changes (presumably #1889) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels: |
|
Thank you for the review. I rebased the changes onto #1889 and added a deprecation notice. Is this what you had in mind or should the warning be placed more prominently? |
|
@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author |
|
Error: The feature Please let |
Allow contributors to label issues via rustbot Now bors suggests contributors label PRs with the status labels, e.g.: #1902 (comment) This allows it, and for issues as well.
We leave IPPROTO_MAX as is for the time being. However, in recent kernel releases IPPROTO_MAX is actually higher and reflects the addition of IPPROTO_MPTCP.
|
@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author |
JohnTitor
left a comment
JohnTitor
left a comment
There was a problem hiding this comment.
r=me once all comments are addressed.
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
|
Thanks! |
|
📌 Commit 7f2619f has been approved by |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
5 participants
The Linux kernel recently gained support for Multipath TCP, a protocol which builds upon TCP. This patch adds
IPPROTO_MPTCPto open new sockets andTCP_ULPto query the upper layer protocol of traditional TCP sockets (which is set tomptcpfor all underlying connections)Source: tcp: Define IPPROTO_MPTCP
cc #1896