Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon. Please see the contribution instructions for more information. |
|
@rustbot label: +O-arm |
|
r? @JohnTitor |
|
@JohnTitor Why did it get blocked? |
|
We need an internal decision for this, sorry about that. |
Oh yeah don’t worry, I was just puzzled by the block without a message. Take all the time needed. |
|
@JohnTitor I don't want to come off as insistent, but it's been over a month and I received no info. Is there any chance this will get merged? It's not a problem if it won't, I just want to know if I should continue to work seriously on this project so that I may set my priorities correctly. |
|
This isn't blocked by me, but a team and they are busy with other work, so I cannot tell you when decision is made. And I don't have enough time to do open source work right now so cannot push the process, sorry about that. |
|
Fixed the standards for the networking, matching the latest version of the compiler. |
Meziu
force-pushed
the
master
branch
4 times, most recently
from
6761f3c to
b3363cd
Compare
|
@JohnTitor another month has passed, any news? What team needs to make a decision, and what is it about? There isn't a lot of transparency going on right now. You mentioned you're busy right now, is there anyone else who can review this? |
|
r? @rust-lang/libc |
|
I chased down the various threads related to this issue. It seems that this is blocked on this comment by @skade which expresses concerns about bindings to vendor-specific APIs. However this PR only creates bindings to newlib standard C APIs so I think it is fine to merge. @bors r+ |
|
📌 Commit 98ef7e7 has been approved by |
ARMv6K Horizon OS support Added support for the Horizon OS Nintendo 3DS system `Newlib` declarations. Edit: after some changes, networking is now stable with standardized API.
Yes, that is indeed the reason why this PR is made to be this way. Glad to see it solved. 😃 |
|
💔 Test failed - checks-actions |
|
@bors retry |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
armv7 PSVita OS support via newlib Added support for ps vita via newlib. Similar to #2480, but for a different device. I'm working on adding support of std for vita, and this is essentially a prerequisite.
armv7 PSVita OS support via newlib Added support for ps vita via newlib. Similar to #2480, but for a different device. I'm working on adding support of std for vita, and this is essentially a prerequisite.
8 participants
Added support for the Horizon OS Nintendo 3DS system
Newlibdeclarations.Edit: after some changes, networking is now stable with standardized API.