Skip to content

Add newer-api Cargo feature#3488

Closed
JohnTitor wants to merge 1 commit into
rust-lang:mainfrom
JohnTitor:newer-api-cargo-feature
Closed

Add newer-api Cargo feature#3488
JohnTitor wants to merge 1 commit into
rust-lang:mainfrom
JohnTitor:newer-api-cargo-feature

Conversation

@JohnTitor

Copy link
Copy Markdown
Member

This is an attempt to accept the breakage-candidates without a major release.

@rustbot

rustbot commented Dec 19, 2023

Copy link
Copy Markdown
Collaborator

@JohnTitor: no appropriate reviewer found, use r? to override

@JohnTitor

Copy link
Copy Markdown
Member Author

I expect this will gate breaking changes (adding members to struct, changing const's values, etc...) but it would add complexity, any opinions or better options are definitely welcome!
cc @rust-lang/crate-maintainers I'd like to hear anyone's opinion.

@Amanieu

Amanieu commented Dec 19, 2023

Copy link
Copy Markdown
Member

I don't think this will work due to the way Cargo feature unification works. Enabling this feature in one crate could end up breaking a completely unrelated crate. Considering how widely used libc is, I think this will be too brittle for any practical use.

@JohnTitor

Copy link
Copy Markdown
Member Author

Hmm, I see! Do you have any other ways to accept breakage candidates until we can release libc 0.3? 🤔 (Or, would releasing libc 0.3 be the best way here?)

@Amanieu

Amanieu commented Dec 19, 2023

Copy link
Copy Markdown
Member

I think the best way forward would be to follow the implementation plan in #3248.

@JohnTitor

Copy link
Copy Markdown
Member Author

Sure, let's follow it then!

@JohnTitor JohnTitor closed this Dec 19, 2023
@JohnTitor JohnTitor deleted the newer-api-cargo-feature branch December 19, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants