Set type of POSIX_SPAWN_* flags to c_short#3629
Merged
Merged
Conversation
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
Collaborator
|
Some changes occurred in OpenBSD module cc @semarie |
Member
Author
|
Docker failure is unrelated |
semarie
approved these changes
Mar 23, 2024
semarie
left a comment
semarie
left a comment
Contributor
There was a problem hiding this comment.
LGTM for OpenBSD. thanks.
Changing the type from `c_int` to `c_short` will likely not break existing programs. It might introduce warnings about no-longer needed conversions to `c_short` though.
JohnTitor
approved these changes
Apr 29, 2024
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 17, 2024
These were changed in f62eb02 ("Set type of POSIX_SPAWN_* flags to c_short"). PR: <rust-lang#3629>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing the type from
c_inttoc_shortwill likely not break existing programs. It might introduce warnings about no-longer needed conversions toc_shortthough.Fixes #3627